-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track include and TLS certs with Reloader #164
Conversation
if len(fileSet) == 0 { | ||
nconfig.ConfigFiles = []string{"/etc/nats-config/gnatsd.conf"} | ||
nconfig.WatchedFiles = []string{"/etc/nats-config/gnatsd.conf"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is old code, but is there an opportunity to update this to /etc/nats-config/nats.conf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only left it in the event that someone is still using that default, but that's probably pretty unlikely at this point so we can change it if no one has concerns.
While we are on the subject of regex, I guess we should techncially unit test that the regex handles all of these cases. Can you think of any others? This is just for the include, but we'd need something similar for TLS certs too
|
Golang regex doesn't support negative lookaheads, but I updated the code to handle includes with |
…cher Deps updates
a66032f
to
8ee50b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
include
s and certs in the NATS config and add them to the file watcher