Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDIT] ADR-32 Add comments around subject #245

Merged
merged 3 commits into from
Oct 11, 2023
Merged

[EDIT] ADR-32 Add comments around subject #245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64f34b0
[EDIT] ADR-32 Add comments around subject
scottf Oct 11, 2023
ab690d5
[EDIT] ADR-32 Add comments around subject
scottf Oct 11, 2023
aaebba9
[EDIT] ADR-32 Add comments around subject
scottf Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion adr/ADR-32.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,14 @@ Returns a JSON having the following structure:
```typescript
// EndpointInfo
{
/**
* The name of the endpoint
*/
name: string,
/**
* The subject on which the endpoint is registered.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simply say, the subject where the endpoint is listening. - how you got there doesn't matter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

* This includes the full path when the endpoint is part of a group
*/
subject: string,
queueGroup: string,
/**
Expand Down Expand Up @@ -215,7 +222,8 @@ The type for this is `io.nats.micro.v1.ping_response`.
*/
name: string;
/**
* The subject on which the endpoint is registered
* The subject on which the endpoint is registered.
* This includes the full path when the endpoint is part of a group
*/
subject: string;
/**
Expand Down