Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalized Multi-cluster and Leafnode toplogies #249

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

ripienaar
Copy link
Contributor

No description provided.

@ripienaar
Copy link
Contributor Author

ripienaar commented Oct 18, 2023

The idea here is to formalize topologies we support and to minimise down the configuration options that users have to supply - rather than use the JetStream structs for those, we reframe things and add KV specific terminology and structs so we can model toplogies rather than plumbing.

TBD here after initial discussions complete is to make some adjustments to the main KeyValue to be able to figure out if a thing is a Aggregate and to get at this config.

@ripienaar ripienaar requested review from aricart and jnmoyne October 18, 2023 14:42
@ripienaar
Copy link
Contributor Author

@jnmoyne and @aricart this is a draft PR lets chat a bit about this

@ripienaar
Copy link
Contributor Author

Capturing some comments from a call:

  • Do not use Replica as its overloading existing term, stick to Mirror its fine really
  • We will need to support adding that have hand supplied API prefixes and such since the edge may not have full access to the origin bucket at all to support the bucket orierntated API.

Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the exception of the items we talked about (mirror, etc)

@ripienaar ripienaar force-pushed the kv_topologies branch 3 times, most recently from 444006f to 72774e3 Compare October 19, 2023 14:49
@ripienaar ripienaar marked this pull request as ready for review October 23, 2023 16:49
@ripienaar ripienaar merged commit 85f017e into main Oct 25, 2023
1 check passed
@ripienaar ripienaar deleted the kv_topologies branch October 25, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants