Add advisories for pull consumer groups #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmoyne
reviewed
Aug 1, 2024
ripienaar
force-pushed
the
pinned_advisories
branch
from
b5a7e02 to
49ed0c9
Compare
Jarema
requested changes
Aug 2, 2024
adr/ADR-42.md
Outdated
| const JSStreamGroupPinnedAdvisoryType = "io.nats.jetstream.advisory.v1.consumer_group_pinned" | ||
|
|
||
| // JSStreamGroupPinnedAdvisory that a group switched to a new pinned client |
There was a problem hiding this comment.
Suggested change
| // JSStreamGroupPinnedAdvisory that a group switched to a new pinned client | |
| // JSStreamGroupPinnedAdvisory indicates that a group switched to a new pinned client |
Jarema
requested changes
Aug 12, 2024
Signed-off-by: R.I.Pienaar <[email protected]>
ripienaar
force-pushed
the
pinned_advisories
branch
from
49ed0c9 to
c523e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.