Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simplified ordered consuming when a delivery policy was set. #1251

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Fix simplified ordered consuming when a delivery policy was set. #1251

merged 5 commits into from
Nov 15, 2024

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Nov 14, 2024

No description provided.

@scottf scottf requested a review from roeschter November 14, 2024 20:51
roeschter
roeschter approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@roeschter roeschter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - tests flawlessly in chaos test with many for the sample code where we first saw the issue. Survives reconnects.

@scottf scottf merged commit 1bf06d5 into main Nov 15, 2024
4 checks passed
@scottf scottf deleted the fix-ordered-with-delivery-policy branch November 15, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeschter roeschter roeschter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @roeschter