Construct Options builder from properties file for user. #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Sep 13, 2023
| * <p>If {@link Options#PROP_SECURE PROP_SECURE} is set, the builder will | ||
| * try to get the default context{@link SSLContext#getDefault() getDefault()}. | ||
| * If a context can't be found, no context is set and an IllegalArgumentException is thrown.</p> | ||
| * |
There was a problem hiding this comment.
This text was moved to the build method in a previous PR
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer used to have to load the properties file themselves. Now they can just supply the file path and the Options builder will do it for them.