Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transient dependencies #1361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve transient dependencies #1361

wants to merge 2 commits into from

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 7, 2025

This reduces the dependencies footprint in scenarios when websockets and aws-lc-rs are not used.

Signed-off-by: Tomasz Pietrek [email protected]

@Jarema Jarema force-pushed the improve-ci-coverage branch 2 times, most recently from 8639ecd to 7bd5f3e Compare January 7, 2025 21:39
@Jarema Jarema requested a review from piotrpio January 7, 2025 21:52
@Jarema Jarema marked this pull request as ready for review January 7, 2025 21:52
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jarema added 2 commits January 7, 2025 23:10
Optional dependencies around TLS were pulling in more than it was
necessary. This commit improves that.
Additionally CI was not testing all TLS variants, nor the websockets feature.

Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema force-pushed the improve-ci-coverage branch from 7bd5f3e to a471adc Compare January 7, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants