Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Stream::purge_filter #755

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

caspervonb
Copy link
Collaborator

@caspervonb caspervonb commented Dec 6, 2022

Incremental step towards #745.
Soft deprecation since we can.

@caspervonb caspervonb requested a review from Jarema December 6, 2022 03:13
@caspervonb caspervonb force-pushed the deprecate-purge-subject branch 2 times, most recently from 4de4695 to 45da927 Compare December 6, 2022 15:42
@caspervonb caspervonb force-pushed the deprecate-purge-subject branch 2 times, most recently from db90df3 to 242bea7 Compare December 19, 2022 08:12
@caspervonb caspervonb force-pushed the deprecate-purge-subject branch from 242bea7 to 987407d Compare December 19, 2022 13:45
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspervonb caspervonb merged commit 96c913f into nats-io:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants