-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fetching messages from JetStream #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
consumer-fetch
branch
from
October 8, 2024 15:09
7b0e93f
to
9cef589
Compare
Jarema
requested changes
Oct 14, 2024
Co-authored-by: Tomasz Pietrek <[email protected]>
Co-authored-by: Tomasz Pietrek <[email protected]>
Co-authored-by: Tomasz Pietrek <[email protected]>
Co-authored-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
consumer-fetch
branch
from
October 29, 2024 15:27
ed2f494
to
4daa826
Compare
Jarema
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Consumer.fetch()
method for fetching batches of messages. It also addsJetStreamMessage
and methods for acking messages and checking metadata.Signed-off-by: Piotr Piotrowski [email protected]