Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancellation to async tasks #88

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add cancellation to async tasks #88

merged 1 commit into from
Jan 6, 2025

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Jan 6, 2025

  • added cancellation handling for info and connection established continuations
  • cleaned up handleReconnect() cancellation
  • fixed a bug where maxReconnects(0) causes the client to abandon the initial connect

Addresses #84 #86

Signed-off-by: Piotr Piotrowski [email protected]

Signed-off-by: Piotr Piotrowski <[email protected]>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 2b673cb into main Jan 6, 2025
5 checks passed
@Jarema Jarema deleted the handle-task-cancellation branch January 6, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants