Bench command in multisubject mode subject format improvement #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using nats bench in multisubject mode to generate messages in order to evaluate the amount of memory used by the indexes according to the number of subjects being stored in the stream it is more accurate if all the subjects have the same size. This achieves that by using padding 0 up to the length of the max number of subjects when creating the subjects. Signed-off-by: Jean-Noël Moyne <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
|
Please sign your commit @jnmoyne |
|
Apologies: they were signed but with my new GPG key (old one expired) and I just had not uploaded that new key to GH yet, done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nats bench in multisubject mode to generate messages in order to evaluate the amount of memory used by the indexes according to the number of subjects being stored in the stream it is more accurate if all the subjects have the same size. This achieves that by using padding 0 up to the length of the max number of subjects when creating the subjects.