Add test for ios17 in CI #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 I commit to try the test many times, so I will squash&merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 PR to add iOS17 to GitHub Actions automated testing
It has passed manual testing, but should be added to automated testing if possible.
✋ Pending for wix/AppleSimulatorUtils#117
Permissions must be granted to the Photos app in order to run the test.
There are three ways to grant permissions
1. Run
xcrun simctl privacy~Apple offers this method, but for some reason it did not work.
xcrun simctl privacy booted grant photos studio.midoridesign.galExampleAnd we can't test it on macOS.
2. Auto-tap on authorization dialog with XCTest
This is the only method that has worked so far. And probably works on macOS as well as iOS.
However, I discovered method 3 and discontinued it because it is easier. #77
3. Use wix/AppleSimulatorUtils
It is a third party plugin and worked well, but seems to be buggy in iOS17. And we can't use on macOS.
🗒️ Update 2023 12
Maybe macOS should be tested by TCC See: actions/runner-images#8961
🗒️ Update 2024 01
wix/AppleSimulatorUtils is now deprecated. Need to try again to see if
xcrun simctl privacyis available in this env.🗒️ Update 2024 02
wix/AppleSimulatorUtils is fixed in macOS 14.
iOS 16 simurator is removed in macOS 14, so it needs replacement to 17.