V2/2.0.0b2 compatibility #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22. - [Commits](certifi/python-certifi@2022.12.07...2023.07.22) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Changes dev python minimum to 3.9
Bump certifi from 2022.12.7 to 2023.7.22
…it results on the server instead of getting all results and filtering on the client side.
Adds group_names_raw option to gql_inventory
Updating tests
#237: when searching for cables, use pynautobot's filter() API to lim…
joewesch
reviewed
Sep 7, 2023
| @@ -0,0 +1 @@ | |||
| nautobot-bgp-models @ git+https://github.com/nautobot/nautobot-plugin-bgp-models@v2 | |||
There was a problem hiding this comment.
I ripped out these conditional requirement files in #242. Do we plan on keeping separate 1.X/2.X branches? If so, we should just change the standard requirements file.
There was a problem hiding this comment.
Yes, there will be separation between 1.X and 2.X.
I have seen this PR you mentioned above, I'll have to re-base and follow that.
pszulczewski
force-pushed
the
v2/2.0.0b2_compatibility
branch
from
4c3834b to
9f2a151
Compare
pszulczewski
force-pushed
the
v2/2.0.0b2_compatibility
branch
from
9f2a151 to
284914f
Compare
pszulczewski
force-pushed
the
v2/2.0.0b2_compatibility
branch
from
c3c49e6 to
d7847aa
Compare
pszulczewski
force-pushed
the
v2/2.0.0b2_compatibility
branch
from
d7847aa to
549c7db
Compare
…s, modules tests.
|
Plugin module has issues with getting status field converted to ID. I will look into that while working on issue #244 as it seems to be related. For now marked as TODO. |
jvanderaa
approved these changes
Sep 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for Nautobot 2.X
IPAddressToInterfaceREST API Endpoint nautobot#4249IMPLEMENTATION DECISIONS:
This decision was made based due the fact that locations are hierarchical and name doesn't guarantee that a unique location will be found. This is left to the user to make a unique query (lookup module) to find the location. This aligns to the core team recommendation that for locations PK or a unique set of parameters should be used to identify a location.