Dashboard View #191

jvanderaa · 2022-07-07T18:56:53Z

WIP yet, this is the work towards building a Dashboard view for the components of the circuit maintenance.

Outstanding:

Complete planned dashboard metrics
Integrate functions/methods into Capacity Metrics

nautobot_circuit_maintenance/urls.py

scetron · 2022-07-08T15:47:41Z

I think this is a great addition to the plugin and agree with @glennmatthews that it would make a good plugin landing/home page.

pyproject.toml

jvanderaa · 2022-07-19T16:14:51Z

I'm currently waiting on #195 before I continue on.

nautobot_circuit_maintenance/__init__.py

nautobot_circuit_maintenance/urls.py

nautobot_circuit_maintenance/views.py

nautobot_circuit_maintenance/__init__.py

nautobot_circuit_maintenance/views.py

chadell

Calling the overview view, without any Circuit Maintenance, raises an AttributeError exception

AttributeError at /plugins/circuit-maintenance/maintenance/overview/
'NoneType' object has no attribute 'start_time'
Request Method:	GET
Request URL:	http://localhost:8080/plugins/circuit-maintenance/maintenance/overview/
Django Version:	3.2.15
Exception Type:	AttributeError
Exception Value:	
'NoneType' object has no attribute 'start_time'
Exception Location:	/source/nautobot_circuit_maintenance/views.py, line 169, in get_month_list
Python Executable:	/usr/local/bin/python
Python Version:	3.7.13
Python Path:	
['/source',
 '/usr/local/lib/python3.7/site-packages/git/ext/gitdb',
 '/source',
 '/usr/local/bin',
 '/usr/local/lib/python37.zip',
 '/usr/local/lib/python3.7',
 '/usr/local/lib/python3.7/lib-dynload',
 '/root/.local/lib/python3.7/site-packages',
 '/usr/local/lib/python3.7/site-packages',
 '/source',
 '/usr/local/lib/python3.7/site-packages/gitdb/ext/smmap']
Server time:	Wed, 24 Aug 2022 07:08:07 +0000

chadell

Accessing the overview view with a CircuitMaintenance without circuits, trigger a ZeroDivisionError exception

ZeroDivisionError at /plugins/circuit-maintenance/maintenance/overview/
division by zero
Request Method:	GET
Request URL:	http://localhost:8080/plugins/circuit-maintenance/maintenance/overview/
Django Version:	3.2.15
Exception Type:	ZeroDivisionError
Exception Value:	
division by zero
Exception Location:	/source/nautobot_circuit_maintenance/views.py, line 69, in setup
Python Executable:	/usr/local/bin/python
Python Version:	3.7.13
Python Path:	
['/source',
 '/usr/local/lib/python3.7/site-packages/git/ext/gitdb',
 '/source',
 '/usr/local/bin',
 '/usr/local/lib/python37.zip',
 '/usr/local/lib/python3.7',
 '/usr/local/lib/python3.7/lib-dynload',
 '/root/.local/lib/python3.7/site-packages',
 '/usr/local/lib/python3.7/site-packages',
 '/source',
 '/usr/local/lib/python3.7/site-packages/gitdb/ext/smmap']
Server time:	Wed, 24 Aug 2022 07:09:54 +0000

chadell

I create a CM for the next 30 Days, and is not showing up in the dashboard (this circuit is not associated to a Device)

nautobot_circuit_maintenance/navigation.py

…n-circuit-maintenance into jv_cm_dashboard

jvanderaa · 2022-09-01T12:26:40Z

"Average Duration of Maintenances" is always 0? I added some future circuit maintenances, and always show as 0

Corrected. The seconds property was initially giving good results. But the proper method to use was total_seconds() to get the duration within seconds on a timedelta object.

README.md

...circuit_maintenance/templates/nautobot_circuit_maintenance/circuit_maintenance_overview.html

nautobot_circuit_maintenance/views.py

pyproject.toml

Co-authored-by: Glenn Matthews <[email protected]>

…n-circuit-maintenance into jv_cm_dashboard

nautobot_circuit_maintenance/views.py

glennmatthews · 2022-09-06T12:59:33Z

nautobot_circuit_maintenance/tests/test_views.py

+        return f"plugins:{self.model._meta.app_label}:{self.model._meta.model_name}_{{}}"
+
+    def assertInstanceEqual(self, instance, data, api=False):  # pylint: disable=arguments-differ
+        """Used to overwrite inbuilt function. Causing type issues for datetimepicker."""


Doesn't ring a bell to me, sorry.

...circuit_maintenance/templates/nautobot_circuit_maintenance/circuit_maintenance_overview.html

…nance/circuit_maintenance_overview.html Co-authored-by: Glenn Matthews <[email protected]>

chadell

It's almost a 👍 , I would only simply the testing of the new view (as suggested by Glenn) with a simpler test class, without all the tests that apply to a model, but in this case it's only for an extra view. It should get rid of a lot of the skip that are not adding any value

jvanderaa · 2022-09-08T14:23:19Z

Done @chadell

chadell

LGTM
🎉 Amazing work Josh!
I see this just a first iteration of the dashboard, where we could extend and add useful information as we add more features.

Regarding testing, for the assertInstanceEqual weirdness, I would create a housekeeping issue to fix it.

chadell · 2022-09-08T16:54:07Z

...circuit_maintenance/templates/nautobot_circuit_maintenance/circuit_maintenance_overview.html

+{% table_config_form table table_name="ObjectTable" %}
+{% endblock %}
+{% block javascript %}
+<script src="{% static 'js/tableconfig.js' %}"></script>


@jvanderaa , could you give explain (point to doc) what are we using this for?

@itdependsnetworks I took this from the GC plugin. Any insight?

Removed it for now. It is used for table selection.

Let's get this merged and released?

It's used for customizing a table view to specify which columns are displayed. If you're removing it, you should also remove the table_config_form template tag as well.

scetron

Looks good to me

...circuit_maintenance/templates/nautobot_circuit_maintenance/circuit_maintenance_overview.html

…nance/circuit_maintenance_overview.html Co-authored-by: Christian Adell <[email protected]>

chadell

LGTM

jvanderaa added 3 commits July 6, 2022 21:45

First set of dashboard view.

35de9fe

Moves to using queryset to gather maintenances

b6120df

Calculate future maintenances

f1b4c95

jvanderaa requested review from chadell, glennmatthews, pke11y and scetron as code owners July 7, 2022 18:56

jvanderaa marked this pull request as draft July 7, 2022 18:56

glennmatthews reviewed Jul 7, 2022

View reviewed changes

nautobot_circuit_maintenance/urls.py Show resolved Hide resolved

jvanderaa added 3 commits July 8, 2022 20:44

Finishes the dashboard page.

2a2f601

Adds dashboard as home view

7c72b1c

Updates for tests.

21bfa49

glennmatthews reviewed Jul 11, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

jvanderaa added 3 commits August 11, 2022 09:41

Merge branch 'develop' into jv_cm_dashboard

5aaffb8

Updates for the dashboard.

3e6fa1f

Updates flake8 setup

9f12c93

jvanderaa marked this pull request as ready for review August 19, 2022 14:04

Updates views for QA

a72f167

chadell changed the title ~~WIP: Dashboard View~~ Dashboard View Aug 23, 2022

chadell reviewed Aug 24, 2022

View reviewed changes

chadell requested changes Aug 24, 2022

View reviewed changes

chadell reviewed Aug 24, 2022

View reviewed changes

nautobot_circuit_maintenance/navigation.py Outdated Show resolved Hide resolved

jvanderaa added 4 commits August 25, 2022 21:31

Remove left over learning.

87d592b

Updates for views and documentation.

095902d

Updates and adds tests!

70a5b86

Updates dashboard name in menu.

c83c9b3

jvanderaa added 2 commits September 1, 2022 07:25

Uses total_seconds() method instead of seconds.

de1f9cc

Merge branch 'jv_cm_dashboard' of github.com:jvanderaa/nautobot-plugi…

b73f8e0

…n-circuit-maintenance into jv_cm_dashboard

jvanderaa requested review from chadell and glennmatthews and removed request for glennmatthews and chadell September 1, 2022 12:26

glennmatthews reviewed Sep 2, 2022

View reviewed changes

jvanderaa and others added 4 commits September 2, 2022 09:11

Update README.md

48a8f5a

Co-authored-by: Glenn Matthews <[email protected]>

Updates for many comments.

160abea

Merge branch 'jv_cm_dashboard' of github.com:jvanderaa/nautobot-plugi…

433a20e

…n-circuit-maintenance into jv_cm_dashboard

Simplifies month calculations.

fd97fb1

glennmatthews reviewed Sep 6, 2022

View reviewed changes

jvanderaa and others added 2 commits September 6, 2022 12:34

Update nautobot_circuit_maintenance/templates/nautobot_circuit_mainte…

5636abc

…nance/circuit_maintenance_overview.html Co-authored-by: Glenn Matthews <[email protected]>

Updates to remove unnecessary code.

2c8dcc1

jvanderaa requested a review from chadell September 6, 2022 19:11

chadell reviewed Sep 7, 2022

View reviewed changes

Updates tests for one without all the views.

7343b52

chadell previously approved these changes Sep 8, 2022

View reviewed changes

chadell reviewed Sep 8, 2022

View reviewed changes

Removes unused js import (for now).

0759785

jvanderaa dismissed chadell’s stale review via 0759785 September 9, 2022 14:21

scetron previously approved these changes Sep 9, 2022

View reviewed changes

chadell reviewed Sep 12, 2022

View reviewed changes

...circuit_maintenance/templates/nautobot_circuit_maintenance/circuit_maintenance_overview.html Outdated Show resolved Hide resolved

jvanderaa dismissed scetron’s stale review via f6fac8a September 12, 2022 21:23

Update nautobot_circuit_maintenance/templates/nautobot_circuit_mainte…

f6fac8a

…nance/circuit_maintenance_overview.html Co-authored-by: Christian Adell <[email protected]>

chadell approved these changes Sep 13, 2022

View reviewed changes

chadell merged commit 9606a95 into nautobot:develop Sep 13, 2022

chadell mentioned this pull request Sep 13, 2022

General Dashboard Page #189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard View #191

Dashboard View #191

jvanderaa commented Jul 7, 2022 •

edited

Loading

scetron commented Jul 8, 2022

jvanderaa commented Jul 19, 2022

chadell left a comment

chadell left a comment

chadell left a comment •

edited

Loading

jvanderaa commented Sep 1, 2022

glennmatthews Sep 6, 2022

chadell left a comment

jvanderaa commented Sep 8, 2022

chadell left a comment

chadell Sep 8, 2022

jvanderaa Sep 8, 2022

jvanderaa Sep 9, 2022

jvanderaa Sep 9, 2022

glennmatthews Sep 9, 2022

scetron left a comment

chadell left a comment

Dashboard View #191

Dashboard View #191

Conversation

jvanderaa commented Jul 7, 2022 • edited Loading

scetron commented Jul 8, 2022

jvanderaa commented Jul 19, 2022

chadell left a comment

Choose a reason for hiding this comment

chadell left a comment

Choose a reason for hiding this comment

chadell left a comment • edited Loading

Choose a reason for hiding this comment

jvanderaa commented Sep 1, 2022

glennmatthews Sep 6, 2022

Choose a reason for hiding this comment

chadell left a comment

Choose a reason for hiding this comment

jvanderaa commented Sep 8, 2022

chadell left a comment

Choose a reason for hiding this comment

chadell Sep 8, 2022

Choose a reason for hiding this comment

jvanderaa Sep 8, 2022

Choose a reason for hiding this comment

jvanderaa Sep 9, 2022

Choose a reason for hiding this comment

jvanderaa Sep 9, 2022

Choose a reason for hiding this comment

glennmatthews Sep 9, 2022

Choose a reason for hiding this comment

scetron left a comment

Choose a reason for hiding this comment

chadell left a comment

Choose a reason for hiding this comment

jvanderaa commented Jul 7, 2022 •

edited

Loading

chadell left a comment •

edited

Loading