Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Drop Python 3.6 #195

Merged
merged 25 commits into from
Aug 11, 2022
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
[flake8]
# E501: Line length is enforced by Black, so flake8 doesn't need to check it
# W503: Black disagrees with this rule, as does PEP 8; Black wins
ignore = E501, W503
# E402: Module level import not at top of file, due to importlib check
# E701: Flake8 Catches errors in data model
ignore = E501, W503, E701
exclude = nautobot_circuit_maintenance/__init__.py
jvanderaa marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ jobs:
strategy:
fail-fast: true
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9"]
nautobot-version: ["1.1.5"]
python-version: ["3.7", "3.8", "3.9"]
nautobot-version: ["1.1.5", "1.2.11", "1.3.7"]
runs-on: "ubuntu-20.04"
env:
INVOKE_NAUTOBOT_CIRCUIT_MAINTENANCE_PYTHON_VER: "${{ matrix.python-version }}"
Expand All @@ -126,8 +126,8 @@ jobs:
strategy:
fail-fast: true
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9"]
nautobot-version: ["1.1.5"]
python-version: ["3.7", "3.8", "3.9"]
nautobot-version: ["1.1.5", "1.2.11", "1.3.7"]
scetron marked this conversation as resolved.
Show resolved Hide resolved
runs-on: "ubuntu-20.04"
env:
INVOKE_NAUTOBOT_CIRCUIT_MAINTENANCE_PYTHON_VER: "${{ matrix.python-version }}"
Expand Down
7 changes: 5 additions & 2 deletions development/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NAUTOBOT_VER="1.0.1"
ARG NAUTOBOT_VER="1.3.5"
ARG PYTHON_VER=3.8
scetron marked this conversation as resolved.
Show resolved Hide resolved
FROM ghcr.io/nautobot/nautobot-dev:${NAUTOBOT_VER}-py${PYTHON_VER}

Expand All @@ -9,7 +9,7 @@ ARG NAUTOBOT_ROOT=/opt/nautobot

ENV NAUTOBOT_ROOT ${NAUTOBOT_ROOT}

RUN apt-get update && apt-get install -y gcc libmariadb-dev-compat libmariadb-dev
RUN apt-get update && apt-get install -y gcc libmariadb-dev-compat libmariadb-dev libgeos-dev

WORKDIR $NAUTOBOT_ROOT

Expand All @@ -26,6 +26,9 @@ WORKDIR /source
# Copy in only pyproject.toml/poetry.lock to help with caching this layer if no updates to dependencies
COPY poetry.lock pyproject.toml /source/

# Add Nautobot to the poetry file for testing
RUN poetry add nautobot==$NAUTOBOT_VER

# --no-root declares not to install the project package since we're wanting to take advantage of caching dependency installation
# and the project is copied in and installed after this step
RUN poetry install --no-interaction --no-ansi --no-root -E metrics
Expand Down
2 changes: 1 addition & 1 deletion development/docker-compose.postgres.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: "3.4"

services:
db:
image: "postgres:14-alpine"
image: "postgres:13-alpine"
env_file:
- "dev.env"
- "creds.env"
Expand Down
5 changes: 5 additions & 0 deletions nautobot_circuit_maintenance/tests/test_views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# pylint: disable=duplicate-code
"""Test for Circuit Maintenace Views."""
from unittest import skip
from unittest.mock import patch
from datetime import datetime, timezone
from django.conf import settings
Expand Down Expand Up @@ -69,6 +70,10 @@ def _get_base_url(self):
def assertInstanceEqual(self, instance, data, api=False): # pylint: disable=arguments-differ
"""Used to overwrite inbuilt function. Causing type issues for datetimepicker."""

@skip
def test_has_advanced_tag(self):
jvanderaa marked this conversation as resolved.
Show resolved Hide resolved
pass

@classmethod
def setUpTestData(cls):
"""Setup environment for testing."""
Expand Down
Loading