Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Drop Python 3.6 #195
Updates to Drop Python 3.6 #195
Changes from 15 commits
2edcbd6
571e4ce
2af591c
d2319b4
8904dcc
1401b3a
776b4e9
636dcf4
4ca04e0
d2082eb
db94d3c
402d8ad
5341bed
1f25c37
52baa13
c7cc14f
2749d93
7fd0071
a2e6072
a4b0777
d9e20cf
037d4d8
9d2b62a
73b61fc
15553f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sure looks wrong to me - should either be
@classmethod setUpTestData(cls)
or just simplysetUp(self)
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jvanderaa have you taken care of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the thought? I am not clear in understanding what either is doing immediately. Just disabling pylint rule from the pylint updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not I will take a look more upon my return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@classmethod setUpTestData(cls)
runs once before all tests in this TestCase,setUp(self)
runs before each individual test in this TestCase.@classmethod setUp(cls)
is some sort of weird hybrid between these two and is incorrect. I suspect that changing it tosetUp(self)
should be the correct fix here.