Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Drop Python 3.6 #195

Merged
merged 25 commits into from
Aug 11, 2022
Merged

Updates to Drop Python 3.6 #195

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2edcbd6
Updates to drop Py3.6
jvanderaa Jul 9, 2022
571e4ce
Merge branch 'develop' into drop_py36
jvanderaa Jul 9, 2022
2af591c
Updates flake8 settings
jvanderaa Jul 9, 2022
d2319b4
Merge branch 'drop_py36' of github.com:jvanderaa/nautobot-plugin-circ…
jvanderaa Jul 9, 2022
8904dcc
Updates for test.
jvanderaa Jul 9, 2022
1401b3a
Updates CI.
jvanderaa Jul 9, 2022
776b4e9
Removes attempted testing of py3.10
jvanderaa Jul 9, 2022
636dcf4
Revert version bump.
jvanderaa Jul 11, 2022
4ca04e0
Removed pinning for black issues on <3.7
jvanderaa Jul 11, 2022
d2082eb
Updates CI to test Nautobot.
jvanderaa Jul 11, 2022
db94d3c
Updates flake8 setup.
jvanderaa Jul 11, 2022
402d8ad
Update flake8 settings.
jvanderaa Jul 11, 2022
5341bed
Updates test for passing.
jvanderaa Jul 11, 2022
1f25c37
Updates test to skip inherited test.
jvanderaa Jul 11, 2022
52baa13
Moves pylint disable.
jvanderaa Jul 11, 2022
c7cc14f
Updates tests and Dockerfile
jvanderaa Jul 17, 2022
2749d93
Updates for tests.
jvanderaa Jul 19, 2022
7fd0071
Updates flake8 settings
jvanderaa Jul 19, 2022
a2e6072
Updates poetry lock
jvanderaa Jul 19, 2022
a4b0777
Updates CI
jvanderaa Jul 19, 2022
d9e20cf
Move to latest version for stable.
jvanderaa Jul 20, 2022
037d4d8
Fixes test set up with mysql
jvanderaa Jul 20, 2022
9d2b62a
Update views for consistency.
jvanderaa Aug 9, 2022
73b61fc
Updates test classmethod def
jvanderaa Aug 9, 2022
15553f0
Updating tests
jvanderaa Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ jobs:
fail-fast: true
matrix:
python-version: ["3.7", "3.8", "3.9"]
nautobot-version: ["1.1.5", "1.2.11", "1.3.7"]
nautobot-version: ["1.3.8"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which was the problem with mysql?
BTW, would make sense to leave the nautboto-version to "stable" to always check against hte latest by default? (don't recall if we already commented this point)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable doesn't work. There is a parser error.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying to get things into a working state. What didn't work with MySQL is that I didn't have a matrix set up for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry Josh, I don't get it, because the matrix was already set up before, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for stable. It was set up to test individual versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I understand, not for stable, but the matrix was working well for mysql before, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was. I guess the wording of fix mysql was poor. Probably should have just been update mysql matrix.

include:
- python-version: "3.9"
nautobot-version: "1.2.11"
runs-on: "ubuntu-20.04"
env:
INVOKE_NAUTOBOT_CIRCUIT_MAINTENANCE_PYTHON_VER: "${{ matrix.python-version }}"
Expand Down