Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #583

snaselj · 2023-09-13T10:26:58Z

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "develop",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-plugin-golden-config.git",
    "path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-golden-config",
    "repository_path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-golden-config",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@itdependsnetworks @jeffkala @nkallergis",
        "full_name": "Network to Code, LLC",
        "email": "[email protected]",
        "github_org": "nautobot",
        "plugin_name": "nautobot_golden_config",
        "verbose_name": "Golden Config",
        "plugin_slug": "nautobot-golden-config",
        "project_slug": "nautobot-plugin-golden-config",
        "repo_url": "https://github.com/nautobot/nautobot-plugin-golden-config",
        "base_url": "golden-config",
        "min_nautobot_version": "1.4.0",
        "max_nautobot_version": "1.9999",
        "nautobot_version": "latest",
        "camel_name": "NautobotGoldenConfig",
        "project_short_description": "A plugin for configuration on nautobot",
        "version": "1.0.0",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/golden-config/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/opt/ntc/drift-manager/outputs",
        "_repo_dir": "/opt/ntc/drift-manager/outputs/.cookiecutters/cookiecutter-nautobot-app/nautobot-app"
    },
    "base_branch": "next-2.0",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": []
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "./setup-cookie-golden-config.json",
    "output_dir": "./outputs",
    "push": true,
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "template_dir": "nautobot-app",
    "template_ref": "develop",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false
}

@itdependsnetworks

Template: ``` { "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git", "dir": "nautobot-app", "ref": "develop", "path": null } ``` Cookie: ``` { "remote": "https://github.com/nautobot/nautobot-plugin-golden-config.git", "path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-golden-config", "repository_path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-golden-config", "dir": "", "branch_prefix": "drift-manager", "context": { "codeowner_github_usernames": "@itdependsnetworks @jeffkala @nkallergis", "full_name": "Network to Code, LLC", "email": "[email protected]", "github_org": "nautobot", "plugin_name": "nautobot_golden_config", "verbose_name": "Golden Config", "plugin_slug": "nautobot-golden-config", "project_slug": "nautobot-plugin-golden-config", "repo_url": "https://github.com/nautobot/nautobot-plugin-golden-config", "base_url": "golden-config", "min_nautobot_version": "1.4.0", "max_nautobot_version": "1.9999", "nautobot_version": "latest", "camel_name": "NautobotGoldenConfig", "project_short_description": "A plugin for configuration on nautobot", "version": "1.0.0", "model_class_name": "None", "open_source_license": "Apache-2.0", "docs_base_url": "https://docs.nautobot.com", "docs_app_url": "https://docs.nautobot.com/projects/golden-config/en/latest", "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git", "_output_dir": "/opt/ntc/drift-manager/outputs", "_repo_dir": "/opt/ntc/drift-manager/outputs/.cookiecutters/cookiecutter-nautobot-app/nautobot-app" }, "base_branch": "next-2.0", "remote_name": "origin", "pull_request_strategy": "PullRequestStrategy.CREATE", "post_actions": [] } ``` CLI Arguments: ``` { "cookie_dir": "", "input": false, "json_filename": "./setup-cookie-golden-config.json", "output_dir": "./outputs", "push": true, "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git", "template_dir": "nautobot-app", "template_ref": "develop", "pull_request": null, "post_action": [], "disable_post_actions": false } ```

snaselj · 2023-09-13T10:30:50Z

This PR is created by the Drift Manager, going to manually clean it up. After that, I'll mark it as a ready for review.

snaselj · 2023-09-13T12:14:34Z

Moved docs updates to separate PR #584

snaselj · 2023-09-13T12:15:20Z

This PR is cleaned up now, ready for review @itdependsnetworks

nautobot_golden_config/tests/test_basic.py

itdependsnetworks · 2023-09-13T13:07:39Z

.github/workflows/ci.yml

@@ -10,6 +13,8 @@ on: # yamllint disable-line rule:truthy rule:comments
  pull_request: ~

 env:
+  # TODO Fix to be repository name


As we go to 2.0, this makes sense to fix.

.github/workflows/upstream_testing.yml

nautobot_golden_config/jobs.py

* Update version statements * Replace broken imports * Swap Region/Site to Location * Fix/skip test cases * Change filters for 2.x * Remove scope property * Remove code around csv import/export per 2.x changes * Change some platform slug uses to network_driver * Remove remaining references to slugs in core models * Switch tag filter to tags * Remove custom get_absolute_url method * Remove management command, move to new dispatcher method, fix job logging and signature * Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool (#583) * chore: Move docs changes to separate pr #584 * fix: Update poetry lock * fix: Pylint * fix: PR comments * fix: Job invocation * Jmcgill/2.x jobs rebase (#595) * Start jobs migration * todos updates (#598) * Move to new dispatcher, move compliant to device tab, update locations/tags filters/forms, * remove platform mapping. * Remove slugs added by Config Remediation work (#602) * Logging updates, active tab fix, add default_deploy_status, * Migrate config compliance and golden config views to viewsets, upgrade diff2html, remove job inclusion check, migrate gc views away from device model * General cleanup from linters (#615) * Revert list view actions to views, fix logging, dispatcher, call jobs by name, fix JS failures catching, run lock * Re-lock, and use hyperlinked_object * fix GoldenConfigSettingForm * downgrade django-pivot to 1.8.1 * Fix failing notes_url test (#625) * bump version, remove slugify, remove commit from config deploy, simplify serialzer, * Fix some more tests for 2.0 (#631) * Update git, logger bug, update processor * logger updates, add to request object, linter * audit linkable retrieve links, link configs vs show them * fix status link * Fix execute menu, extra context in GC overview, expanded to support RC4 * update gitrepo flow, switch to core get_app_settings_or_config, update test * Invert Completed logic * Rename network_driver_mapper to network_driver_mappings (#639) * Add logic to warn when GoldenConfig is out of sync (#629) * Add Job to sync GoldenConfig * update & clean up processor logic, fix reference to .url * fix datasources yaml key to network_driver but backwards to _slug * fix js issue where was too greedy in selection, add copy button * fix filtering on configplans * Add back constance code and clean up json view code (#642) * version update and remove json/yaml toggle * fix api that populates filterform for plan and deploy results * Start on migration/release docs, make booleans more consistent, add error codes framework, move to SearchFilter objects, clean up imports, add copy button to compliance retrieve view, * Migration docs updates, 2.0 release notes, remove dispatcher references * add custom dispatcher docs, update secrets docs, add constance docs, add error code links to other repos * update dependencies, fix or skip tests, minor doc updates --------- Co-authored-by: Jacob McGill <[email protected]> Co-authored-by: Jacob McGill <[email protected]> Co-authored-by: Jan Snasel <[email protected]> Co-authored-by: bakebot <[email protected]> Co-authored-by: Hanlin Miao <[email protected]> Co-authored-by: Gary Snider <[email protected]> Co-authored-by: Bryan Culver <[email protected]> Co-authored-by: mzb <[email protected]> Co-authored-by: John Anderson <[email protected]> Co-authored-by: Jeff Kala <[email protected]>

snaselj requested review from itdependsnetworks, jeffkala and nkallergis as code owners September 13, 2023 10:26

snaselj marked this pull request as draft September 13, 2023 10:29

snaselj added 3 commits September 13, 2023 11:57

chore: Manual fixes

008169b

fix: Syntax error

c7c5ed8

fix: Black

7210bd9

snaselj force-pushed the drift-manager/pr branch from 7926f58 to 7210bd9 Compare September 13, 2023 11:58

chore: Move docs changes to separate pr #584

24dc06f

snaselj marked this pull request as ready for review September 13, 2023 12:15

snaselj added 2 commits September 13, 2023 12:51

fix: Update poetry lock

38d4d1a

fix: Pylint

57c51dc

itdependsnetworks reviewed Sep 13, 2023

View reviewed changes

nautobot_golden_config/tests/test_basic.py Outdated Show resolved Hide resolved

itdependsnetworks reviewed Sep 13, 2023

View reviewed changes

.github/workflows/upstream_testing.yml Show resolved Hide resolved

itdependsnetworks reviewed Sep 13, 2023

View reviewed changes

nautobot_golden_config/jobs.py Outdated Show resolved Hide resolved

snaselj added 2 commits September 13, 2023 13:33

fix: PR comments

976c43f

fix: Job invocation

7476c93

itdependsnetworks approved these changes Sep 13, 2023

View reviewed changes

itdependsnetworks merged commit 718b18e into next-2.0 Sep 13, 2023
9 of 15 checks passed

snaselj deleted the drift-manager/pr branch October 16, 2023 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #583

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #583

snaselj commented Sep 13, 2023

snaselj commented Sep 13, 2023

snaselj commented Sep 13, 2023

snaselj commented Sep 13, 2023

itdependsnetworks Sep 13, 2023

snaselj Sep 13, 2023

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #583

Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool #583

Conversation

snaselj commented Sep 13, 2023

snaselj commented Sep 13, 2023

snaselj commented Sep 13, 2023

snaselj commented Sep 13, 2023

itdependsnetworks Sep 13, 2023

Choose a reason for hiding this comment

snaselj Sep 13, 2023

Choose a reason for hiding this comment