Add total_objs_to_delete and remove the table when deleting all objects. #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes bring this into alignment with Nautobot 2.3.11. This also removes the self.store_table, per the TODO it should not be necessary, I was able to confirm through testing in both the unittests and manually in the UI that removing self.store_table did not make any impact to the functionality.
smk4664
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
smk4664
requested review from
gsnider2195,
itdependsnetworks and
jeffkala
and removed request for
itdependsnetworks,
jeffkala and
nkallergis
jeffkala
reviewed
Nov 27, 2024
gsnider2195
approved these changes
Nov 27, 2024
jeffkala
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #831
These changes bring the Config Compliance Bulk Delete views into alignment with Nautobot 2.3.11.
Screenshots