Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap: fix imports for ipam models #642

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

bile0026
Copy link
Contributor

@bile0026 bile0026 commented Jan 6, 2025

Fixes: #641

Fix incorrectly nested classes for IPAM models in the bootstrap models.

@bile0026 bile0026 added type: bug Issues/PRs addressing a bug. integration: bootstrap Issues/PRs for Bootstrap integration labels Jan 6, 2025
@bile0026 bile0026 requested a review from a team as a code owner January 6, 2025 15:36
@bile0026 bile0026 changed the title fix: 🐛 fix imports for ipam models Bootstrap: fix imports for ipam models Jan 6, 2025
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glennmatthews
Copy link
Contributor

I think the right way to pin the poetry version is something like:

      - name: "Setup environment"
        uses: "networktocode/gh-action-setup-poetry-environment@v6"
        with:
          poetry-version: "1.8.4"

@glennmatthews
Copy link
Contributor

I think the right way to pin the poetry version is something like:

      - name: "Setup environment"
        uses: "networktocode/gh-action-setup-poetry-environment@v6"
        with:
          poetry-version: "1.8.4"

This would be a separate "job"?

I don't think so - think it's just needed in each step that's calling that action.

@bile0026 bile0026 merged commit 668308c into develop Jan 7, 2025
15 checks passed
@jdrew82 jdrew82 deleted the bootstrap_fix_imports branch January 7, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: bootstrap Issues/PRs for Bootstrap integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import issue with IPAM models when DLM app not installed
3 participants