Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip OOB IP address population if mgmt tenant listed in ignore_tenant #665

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Skip OOB IP address population if mgmt tenant listed in ignore_tenant #665

merged 2 commits into from
Jan 16, 2025

Conversation

kingfetty
Copy link
Contributor

Closes: #564

What's Changed

Skip OOB IP address population if mgmt tenant listed in ignore_tenant

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see [the documentation]

@kingfetty kingfetty requested review from chadell and a team as code owners January 16, 2025 14:17
@jdrew82
Copy link
Contributor

jdrew82 commented Jan 16, 2025

@kingfetty can you fix the conflict on the changelog file?

jdrew82
jdrew82 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 added type: enhancement New feature or request integration: ciscoaci Issues/PRs for Cisco ACI integration. type: bug Issues/PRs addressing a bug. and removed type: enhancement New feature or request labels Jan 16, 2025
@jdrew82 jdrew82 merged commit 8ff0d18 into nautobot:develop Jan 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

@chadell chadell Awaiting requested review from chadell chadell is a code owner

Assignees

@kingfetty kingfetty

Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. type: bug Issues/PRs addressing a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling Ignored Tenants in IP Address Synchronization to Prevent Tenant.DoesNotExist Exceptions
2 participants
@kingfetty @jdrew82