added some tasks for soft stop and start and for showing logs #97
Conversation
…hanged the stop to show that containers are deleted
| @@ -160,7 +160,7 @@ def restart(context): | |||
| @task | |||
| def stop(context): | |||
| """Stop Nautobot and its dependencies.""" | |||
| print("Stopping Nautobot...") | |||
| print("Stopping Nautobot (deleting containers)...") | |||
There was a problem hiding this comment.
My only concern with this phrasing is that someone new to Docker might think they're losing data when this is done due to the "delete" word being used. I'd say we should probably have some documentation too around why someone might want to use down vs stop, etc.
There was a problem hiding this comment.
I suppose you are right, would you like to include something in the comments at line 162? I did get confused when my containers got deleted when using this option (I probably should have read the doc more closely as well).
Or we would modify the message adding info about the volumes, for example:
print("Stopping Nautobot (deleting containers but keeping volumes and data)...")
There was a problem hiding this comment.
I think it'd make sense to alter the console message to be clearer about what's happening and also documenting what the various invoke task options are. i know we're currently missing the later at this time.
There was a problem hiding this comment.
I agree. I am not sure how to help move this forward though. About presenting the options I think a help message should be defined in a central point in order to avoid repeating it for each option, possibly through a function (preferably) or a global variable. How can I help?
.. also changed the stop to show that containers are deleted when doing invoke stop (it was a surprise the first time I ran it).