Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize #71

Merged
merged 13 commits into from
Jan 29, 2024
Merged

Standardize #71

merged 13 commits into from
Jan 29, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jan 25, 2024 •
edited
Loading

Closes NaN

What's Changed

  • Standardized the development environment and CI checks to test Nautobot 1.6, 2.0, and 2.1 versions.
  • Read current Nautobot version from poetry.lock or installed nautobot package.

To Do

  • Update the documentation accordingly in the separate PR.

@snaselj snaselj marked this pull request as ready for review January 25, 2024 11:41
@snaselj snaselj requested review from cmsirbu, Kircheneer and a team as code owners January 25, 2024 11:41
@snaselj snaselj mentioned this pull request Jan 26, 2024
Merged
3 tasks
cmsirbu
cmsirbu reviewed Jan 29, 2024
View reviewed changes
pyproject.toml
supported_nautobot_versions = [
"1",
"2"
mkdocstrings = "0.22.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some duplication here with the main package dependencies, could you please clean it up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

cmsirbu
cmsirbu approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snaselj snaselj merged commit e774bef into develop Jan 29, 2024
15 checks passed
@snaselj snaselj deleted the u/snaselj-napps-200-standardize branch January 29, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmsirbu cmsirbu cmsirbu approved these changes

@Kircheneer Kircheneer Awaiting requested review from Kircheneer Kircheneer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaselj @cmsirbu