Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e tests on merges to main #729

Open
lorenyu opened this issue Aug 13, 2024 · 3 comments · May be fixed by navapbc/platform-test-nextjs#91
Open

Run e2e tests on merges to main #729

lorenyu opened this issue Aug 13, 2024 · 3 comments · May be fixed by navapbc/platform-test-nextjs#91
Assignees
@rylew1
Labels
scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature workflow: good first issue Good for newcomers
Milestone
1-End-to-end (e2e...

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Aug 13, 2024 •
edited
Loading

Currently e2e tests run on PRs on PR environments. This ticket is to run e2e tests on merges to main on the integrated dev environment.

Design notes

  • Add a new template workflow ci-app-e2e-tests.yml which calls the callable e2e-tests.yml workflow that runs on merges to main
  • Also add a workflow_dispatch trigger for manual runs (and testing during development)
@lorenyu lorenyu added this to the 1-End-to-end (e2e) Testing milestone Aug 13, 2024
@lorenyu lorenyu added type: feature New feature or new functionality to existing feature scope: ci/cd GitHub actions workflows workflow: good first issue Good for newcomers labels Aug 13, 2024
@rylew1
Copy link
Contributor

rylew1 commented Oct 25, 2024 •
edited
Loading

The only way to test/verify this is to merge a PR? - do we want to just create a PR on template-infra and verify that it works on merge to main?

@lorenyu
Copy link
Contributor Author

lorenyu commented Oct 25, 2024

a PR on template-infra definitely won't work since template-infra doesn't have any deployed infrastructure.

i think a reasonable way to test is to add an e2e workflow with two triggers: one trigger on pushes to main, and a manual trigger using workflow_dispatch for testing purposes

@rylew1 rylew1 linked a pull request Nov 18, 2024 that will close this issue
Open
@lorenyu
Copy link
Contributor Author

lorenyu commented Nov 18, 2024

Moving this to blocked for now, I think it'll be easier to do this after we migrated over to Platform CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature workflow: good first issue Good for newcomers
Projects
None yet
Milestone
1-End-to-end (e2e) Testing
Development

Successfully merging a pull request may close this issue.

Run e2e tests on merge to main navapbc/platform-test-nextjs
2 participants
@lorenyu @rylew1