Run e2e tests on merge to main #91
Conversation
| uses: ./.github/workflows/e2e-tests.yml | ||
| with: | ||
| service_endpoint: ${{ inputs.service_endpoint || 'http://app-dev-2093346449.us-east-1.elb.amazonaws.com' }} | ||
| app_name: ${{ inputs.app_name || 'app' }} |
There was a problem hiding this comment.
@lorenyu - I think we need to have this workflow on the default branch / main to run it manually
There was a problem hiding this comment.
Here's a way to run it manually:
- Temporarily add a
pull_requesttrigger to the workflow. This will cause the workflow to run once on your branch. - Remove the
pull_requesttrigger from the workflow. - Now you should be able to manually using the GitHub CLI via
gh workflow run ci-app-e2e-tests.yml --ref rylew/run-e2e-on-merge-to-main
There was a problem hiding this comment.
Oh interesting, haven't used the cli yet. I will hold off on this for now though.
Will the CLI paradigm allow for a service_endpoint to be passed in? - I see it's kind of unclear in the current paradigm - seems like the only way to set it up on template-infra now would be to have the user potentially hardcode their dev environment and app name
|
Hey @rylew1 , thinking about this task a bit more, I think it might be overall simpler/less work if we held off on this task for a bit until we finish migrating everything over to the new Platform CLI. App-specific files like cc @doshitan if you have another perspective or things to add |
Ticket
Resolves navapbc/template-infra#729
Changes
Context for reviewers
Preview environment