Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change/common_testing_internal #3768

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Conversation

rfc3092
Copy link
Contributor

@rfc3092 rfc3092 commented Feb 20, 2025

  • Strømlinjeformer alle grunnleggende application context-tester for å unngå boilerplate. Denne gjør nå noen faktiske tester på endepunkter under /internal og /api.
  • Samler noe felles config i en dolly-application.yml for lettere felles endringer.
  • Fjerner gamle custom /internal/isAlive og /internal/isReady til fordel for Spring Actuators på /internal/health/liveness og /internal/health/readiness.
  • Lagt til fallback for gamle endepunkter med logging (WARN) for å finne ut om disse aktivt brukes (av andre team).
  • Proxies svarer nå med sine egne /internal-endepunkter, og forwarder ikke forespørselen til andre tjenester (noe som er svært lite Kubernetes-vennlig).

Ser at det er en god del custom-kode knyttet til /internal/status. Denne kunne med fordel samles under en felles refaktorering av consumers.*-config som da ville innføre endepunktet for alle apps/proxies. Hvis /internal/status brukes aktivt, da...

@rfc3092 rfc3092 marked this pull request as ready for review February 20, 2025 17:03
@rfc3092 rfc3092 requested a review from a team as a code owner February 20, 2025 17:03
@rfc3092
Copy link
Contributor Author

rfc3092 commented Feb 21, 2025

Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette blir stilig 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants