Skip to content

Commit

Permalink
Merge pull request hotosm#6397 from hotosm/infra-node-18-version
Browse files Browse the repository at this point in the history
Fixes: Circle CI and Docker build failing due to unupdated version of node
  • Loading branch information
ramyaragupathy authored May 1, 2024
2 parents 3115315 + 4dd471e commit 2a53bcc
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
frontend-code-test:
resource_class: large
docker:
- image: cimg/node:16.20
- image: cimg/node:18.19.1
working_directory: /home/circleci/tasking-manager
steps:
- checkout
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
working_directory: /home/circleci/tasking-manager
resource_class: medium
docker:
- image: cimg/python:3.10.7-node
- image: cimg/node:18.19.1
steps:
- checkout
- aws-cli/setup:
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:
working_directory: /home/circleci/tasking-manager
resource_class: large
docker:
- image: cimg/python:3.10.7-node
- image: cimg/node:18.19.1
parameters:
stack_name:
description: "the name of the stack for cfn-config"
Expand Down
2 changes: 1 addition & 1 deletion docs/developers/development-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ The client is the front-end user interface of the Tasking Manager. It is based o
#### Dependencies
The following dependencies must be available _globally_ on your system:
* Download and install [NodeJS LTS v12+](https://nodejs.org/en/) and [yarn](https://classic.yarnpkg.com/en/docs/install)
* Download and install [Node 18.xx](https://nodejs.org/en/download) and [yarn](https://classic.yarnpkg.com/en/docs/install)
* Go into the `frontend` directory and execute `yarn`.
#### Available Scripts
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,6 @@
]
},
"volta": {
"node": "16.20.0"
"node": "18.19.1"
}
}
2 changes: 1 addition & 1 deletion scripts/docker/Dockerfile.frontend
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18 as build
FROM node:18.19.1 as build

WORKDIR /usr/src/app/frontend
COPY frontend .
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker/Dockerfile.frontend_development
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18
FROM node:18.19.1

WORKDIR /usr/src/app

Expand Down

0 comments on commit 2a53bcc

Please sign in to comment.