Skip to content

Commit

Permalink
Test Closing First PluginClient
Browse files Browse the repository at this point in the history
  • Loading branch information
nbauernfeind committed Sep 27, 2024
1 parent d06d3e2 commit 1731f87
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions py/client/tests/test_plugin_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def test_create(self):
self.assertGreater(len(refs), 0)
ref = refs[0]
self.assertEqual(ref.type, "Table")
plugin_client.close()

def test_publish_fetch(self):
plugin_client = self.session.plugin_client(self.session.exportable_objects["plot3"])
Expand Down Expand Up @@ -63,7 +64,6 @@ def test_publish_fetch(self):
sub_session.close()

with self.subTest("Fetchable in the Plugin object"):
self.skipTest("need to wait for https://github.com/deephaven/deephaven-core/issues/5996")
payload, refs = next(plugin_client.resp_stream)
self.assertGreater(len(payload), 0)
self.assertGreater(len(refs), 0)
Expand All @@ -85,7 +85,6 @@ def test_publish_fetch(self):
sub_session.close()

with self.subTest("released Plugin object"):
self.skipTest("need to wait for https://github.com/deephaven/deephaven-core/issues/5996")
sub_session = Session()
server_obj = ServerObject(type="Figure", ticket=shared_ticket)
sub_plugin_client = sub_session.plugin_client(server_obj)
Expand Down

0 comments on commit 1731f87

Please sign in to comment.