commitlint: honor our own WorkflowGuidelines #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webwarrior-ws on Monday can you please verify that this PR is correct? By this, I mean that your review should also make sure that what I'm saying in the commit msg is correct, i.e. does the '?' char guard against both null and undefined? |
|
@webwarrior-ws and please investigate why this PR didn't trigger a CI and why the schedule trigger of this CI workflow hasn't worked for the last 3 months? |
knocte
force-pushed
the
undefinedOccurrence
branch
from
772e3af to
51727b8
Compare
Nevermind. I have no idea how but the workflow was disabled, I had to re-enable it in the GitHub UI, Actions tab. |
knocte
force-pushed
the
undefinedOccurrence
branch
from
51727b8 to
9212367
Compare
The workflow guidelines state that we should avoid the keyword "undefined". This is also extra good because it seems that the `?`-based guards against both null and undefined, at least according to this example: conventional-changelog/commitlint@7ab4bab
knocte
force-pushed
the
undefinedOccurrence
branch
from
322a91f to
131a410
Compare
|
@webwarrior-ws nevermind, had some extra time today and I checked myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow guidelines state that we should avoid the keyword "undefined". This is also extra good because it seems that the ? guards against both null and undefined, at least according to this example:
conventional-changelog/commitlint@7ab4bab