Fix nuget sanitycheck #236

Mersho · 2023-10-17T09:00:28Z

Closes #229
Closes #230
Closes #231
Closes #232

Mersho · 2023-10-17T09:02:08Z

I'm gonna push1by1...

scripts/sanitycheck.fsx

knocte · 2023-10-17T09:04:39Z

You should place the commit titled scripts/sanitycheck: throw if sln doesn't exist as the 1st in the PR, otherwise I don't see its effects in CI.

knocte · 2023-10-17T09:06:21Z

The title "Sanity check file location changes" is very confusing because it doesn't really summarize the PR properly. I think the main issue that makes it very ambiguous is the absence of any verb in it.

scripts/sanitycheck.fsx

knocte · 2023-10-17T09:25:35Z

BTW please beware of your type chenges -> changes.

knocte · 2023-10-17T09:26:01Z

BTW please beware of your type chenges -> changes.

Typo: type->typo

scripts/sanitycheck.fsx

knocte · 2023-10-17T10:51:19Z

Ok, let's squash properly.

knocte · 2023-10-17T11:16:20Z

I did NOT say squash commits into 1.

knocte · 2023-10-18T04:12:15Z

Bring back the sanity check

This PR title would make a future developer think that we had disabled or removed the sanity check and you brought it back. But this is not the case. The sanity check is/was there, you're just fixing one of its steps. Please fix the PR title.

knocte · 2023-10-19T06:57:50Z

Frontend.XF.*: sync & resolve packages conflict

This commit upgrades packages in Frotend.XF.* projects
to be in sync with versions used in Backend.

Sanity check was also complaining before this commit with
the following error:

Also? The error you're quoting is exactly the same as the thing you're referring to before that paragraph. It is not two different problems, so I think you should remove the word also.

knocte · 2023-10-19T06:58:57Z

Fix sanitycheck.fsx script

The sanitycheck script has many steps. Not all of them were broken. Please re-read (paying attention to detail) what I said in #236 (comment)

knocte · 2023-10-19T07:29:36Z

scripts/sanitycheck.fsx: fix dotnet legacy

dotnet legacy??? That sounds so weird and looks like a contradiction, given that in .NET4.x (legacy), the command dotnet doesn't exist. Please change the above to read .NET legacy to avoid any possible confusions.

knocte · 2023-10-20T11:25:32Z

Readjustment sanitycheck.fsx script

Why did you remove the word "fix" from the title? I did not have a complain about that word. Please read again my previous complaint @Mersho .

This got broken when moving solutions to sub /src/ folder [1]. [1] 03db5e5

This commit upgrades packages in Frotend.XF.* projects to be in sync with versions used in Backend. Sanity check was also complaining before this commit with the following error: ``` 190 nuget packages found for solution gwallet.mac-legacy.sln Package found with more than one version: JsonRpcSharp. All occurrences: * Version: 0.98.0--date20230731-1252.git-6788e32. Dependency holder: GWallet.Backend/ * Version: 0.98.0--date20230731-1252.git-6788e32. Dependency holder: GWallet.Backend/ * Version: 0.94.0--date20201018-1119.git-05d4006. Dependency holder: GWallet.Frontend.XF.Android/ * Version: 0.94.0--date20201018-1119.git-05d4006. Dependency holder: GWallet.Frontend.XF.iOS/ Package found with more than one version: Newtonsoft.Json. All occurrences: * Version: 13.0.2. Dependency holder: GWallet.Backend.Tests/ * Version: 13.0.2. Dependency holder: GWallet.Backend/ * Version: 13.0.2. Dependency holder: GWallet.Backend/ * Version: 11.0.2. Dependency holder: GWallet.Frontend.XF.Android/ * Version: 11.0.2. Dependency holder: GWallet.Frontend.XF.iOS/ ``` Closes nblockchain#229 Closes nblockchain#230 Closes nblockchain#231 Closes nblockchain#232 Co-authored-by: Afshin Arani <[email protected]>

As a result of this change, the sanity check works with both dotnet and mono, and the check is based on the environment variables that we set on make.sh. Co-authored-by: Afshin Arani <[email protected]>

knocte reviewed Oct 17, 2023

View reviewed changes