Frontend.Console: show progress when checking balances #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show progress when checking balances so that we can know which currency is the slow one. Fixes #245
knocte
reviewed
Jan 18, 2024
Print dot at the end of "Retrieving balances... " line after all currency names are printed.
|
CI failure is a random bug, unrelated to this PR. |
Thanks for the heads-up, re-running. |
By separating both writes, it could happen that two spaces get written consecutively, instead of concatenating the spaces with the currency first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show progress when checking balances so that we can know which currency is the slow one.
Fixes #245