Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subscription check output and usage string #65

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

hauksta
Copy link
Contributor

@hauksta hauksta commented Jan 13, 2025

Hi,

while using the plugin I noticed an error in the output for the subscription status when defining thresholds, e.g:

./check_pve.py -u <API_USER> -p <API_PASSWORD> -e <API_ENDPOINT> -m subscription -n node1 -w 50 -c 10

Once the license is about to expire the output is:

CRITICAL - {subscription_product_name} will expire in {delta} days ({subscription_due_date})

This PR fixes the output so it will print the correct subscription_product_name and subscription_due_date again.
Also noticed a minor issue in the usage output.

Thanks for making this very useful plugin !

nbuchwitz
nbuchwitz previously approved these changes Feb 13, 2025
@nbuchwitz
Copy link
Owner

I've re-formated your patch so the linter is happy. Otherwise LGTM, thanks!

@nbuchwitz nbuchwitz merged commit 34c7d0e into nbuchwitz:main Feb 13, 2025
1 check passed
@hauksta
Copy link
Contributor Author

hauksta commented Feb 13, 2025

If the linter is happy, I am happy too. :-)
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants