Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property label rendering and code cleanup #329

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Fix property label rendering and code cleanup #329

merged 4 commits into from
Sep 18, 2024

Conversation

jvendetti
Copy link
Member

@jvendetti jvendetti commented Sep 18, 2024 •
edited
Loading

This pull request addresses an issue where certain ontology properties weren't displaying human-readable labels (#326). In addition, it contains some general code cleanup:

  • Fix 163 RuboCop warnings in ApplicationHelper
  • Remove several unused methods methods from ApplicationHelper, including:
    • anonymous_user
    • help_icon
    • isOwner?
    • truncate_with_more
  • Remove several unused view partials from app/views/search

@jvendetti
Account for https in class IDs
a60be0d 
Resolves #326
@jvendetti
Removed unused method
2397bdc
@jvendetti
Remove unused partials
ccc2834
@jvendetti
Fix 163 RuboCop warnings
918eff1 
Also removes three unused methods: isOwner?, truncate_with_more, and help_icon.
@jvendetti jvendetti self-assigned this Sep 18, 2024
@jvendetti jvendetti merged commit 998ae8b into master Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jvendetti jvendetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvendetti