Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: ontology processing notification sends out misleading email about failed archived submission #185

Closed
alexskr opened this issue Feb 6, 2024 · 3 comments
Assignees

Comments

@alexskr
Copy link
Member

alexskr commented Feb 6, 2024

PR #184 and #148 restored new ontology submission processing notifications. When new submission is processed OntoPortal sends two notifications:
1 Success:
image
2: Failure for archived
image

Archive notification gets incorrectly flagged as a failure because archived submission is no longer ready. The second notification about archived submission should not be send out because it might confuse users and I don't think users are interested in getting that information in the first place.

@alexskr alexskr changed the title Notifications: Notifications: ontology processing notification sends out misleading email about failed archived submission Feb 6, 2024
@syphax-bouazzouni
Copy link

Here is a commit that we did at Agroportal to fix that ontoportal-lirmm@6af858a

You can copy the fix if it is good for you

@alexskr
Copy link
Member Author

alexskr commented Feb 6, 2024

Thanks @syphax-bouazzouni, 602a44c fixed the issue
with the notifications about archived submissions.
However, do users even need to know that the previous submission was archived?

@alexskr
Copy link
Member Author

alexskr commented Feb 14, 2024

relates to ncbo/bioportal-project#291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants