Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merging parseOSD functionality into SKB, switching to JSON OSDs next #26

Merged
merged 5 commits into from
Jun 21, 2021
Merged

merging parseOSD functionality into SKB, switching to JSON OSDs next #26

merged 5 commits into from
Jun 21, 2021

Conversation

dylanbeaudette
Copy link
Member

@dylanbeaudette dylanbeaudette commented Jun 21, 2021 •
edited
Loading

This PR represents a transition of OSD-parsing code from the parseOSD repository to SKB.

Strategic TODOs:

  • refactor code that relies on plyr and possibly some of the other dependencies (stringi, purrr, furrr, R.utils)
  • soil color prediction modeling, and model objects: where is the best place to do it / house the results
  • move soil color modeling evaluation to soil-color repository
  • get SC via soilDB::get_soilseries_from_NASIS()
  • possibly move creation of fulltext searching input data to SoilWeb, once artifacts are in place

Technical TODOs:

  • adapt TYPICAL PEDON parsing code to use JSON representation of OSDs

parseOSD Issues:

Outlined in #25.

@dylanbeaudette dylanbeaudette merged commit 0703dcc into main Jun 21, 2021
@brownag brownag deleted the parseOSD-integration branch July 8, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dylanbeaudette