site normalization fixes #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanbeaudette
approved these changes
Jan 21, 2021
brownag
added a commit
that referenced
this pull request
Jan 22, 2021
brownag
added a commit
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171 (which still needs a working example, see #172), also uses
data.table.SD style syntax to replace iteration byddply#157.Adds a new warning if you specify a problematic formula to
site<--- i.e. one that does not produce a result that is 1:1 with the existing site table / profile ID /profile_id()-- leaving data unchanged.This is hopefully OK and sufficient to explain to users who might have expected the horizon var to move to site.
Also, I believe it adds 7 tests which should put us... over 1000!