Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump arboard from 3.2.1 to 3.3.0 #99

Closed
wants to merge 1 commit into from

build(deps): bump arboard from 3.2.1 to 3.3.0

626c527
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

build(deps): bump arboard from 3.2.1 to 3.3.0 #99

build(deps): bump arboard from 3.2.1 to 3.3.0
626c527
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Nov 27, 2023 in 0s

clippy

2 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 0
Note 0
Help 0

Versions

  • rustc 1.74.0 (79e9716c9 2023-11-13)
  • cargo 1.74.0 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (79e9716 2023-11-13)

Annotations

Check failure on line 210 in src/label.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `format!` to build up a string from an iterator

error: use of `format!` to build up a string from an iterator
   --> src/label.rs:207:23
    |
207 |           self.binary = bytes
    |  _______________________^
208 | |             .iter()
209 | |             .map(|byte| format!("{byte:08b}"))
210 | |             .collect::<String>()
    | |________________________________^
    |
help: call `fold` instead
   --> src/label.rs:209:14
    |
209 |             .map(|byte| format!("{byte:08b}"))
    |              ^^^
help: ... and use the `write!` macro here
   --> src/label.rs:209:25
    |
209 |             .map(|byte| format!("{byte:08b}"))
    |                         ^^^^^^^^^^^^^^^^^^^^^
    = note: this can be written more efficiently by appending to a `String` directly
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
    = note: `-D clippy::format-collect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::format_collect)]`

Check failure on line 210 in src/label.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `format!` to build up a string from an iterator

error: use of `format!` to build up a string from an iterator
   --> src/label.rs:207:23
    |
207 |           self.binary = bytes
    |  _______________________^
208 | |             .iter()
209 | |             .map(|byte| format!("{byte:08b}"))
210 | |             .collect::<String>()
    | |________________________________^
    |
help: call `fold` instead
   --> src/label.rs:209:14
    |
209 |             .map(|byte| format!("{byte:08b}"))
    |              ^^^
help: ... and use the `write!` macro here
   --> src/label.rs:209:25
    |
209 |             .map(|byte| format!("{byte:08b}"))
    |                         ^^^^^^^^^^^^^^^^^^^^^
    = note: this can be written more efficiently by appending to a `String` directly
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
    = note: `-D clippy::format-collect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::format_collect)]`