build(deps): bump clap from 4.3.19 to 4.4.8 #113
GitHub Actions / clippy
failed
Nov 13, 2023 in 1s
clippy
2 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 2 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check failure on line 210 in src/label.rs
github-actions / clippy
use of `format!` to build up a string from an iterator
error: use of `format!` to build up a string from an iterator
--> src/label.rs:207:23
|
207 | self.binary = bytes
| _______________________^
208 | | .iter()
209 | | .map(|byte| format!("{byte:08b}"))
210 | | .collect::<String>()
| |________________________________^
|
help: call `fold` instead
--> src/label.rs:209:14
|
209 | .map(|byte| format!("{byte:08b}"))
| ^^^
help: ... and use the `write!` macro here
--> src/label.rs:209:25
|
209 | .map(|byte| format!("{byte:08b}"))
| ^^^^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `-D clippy::format-collect` implied by `-D warnings`
Check failure on line 210 in src/label.rs
github-actions / clippy
use of `format!` to build up a string from an iterator
error: use of `format!` to build up a string from an iterator
--> src/label.rs:207:23
|
207 | self.binary = bytes
| _______________________^
208 | | .iter()
209 | | .map(|byte| format!("{byte:08b}"))
210 | | .collect::<String>()
| |________________________________^
|
help: call `fold` instead
--> src/label.rs:209:14
|
209 | .map(|byte| format!("{byte:08b}"))
| ^^^
help: ... and use the `write!` macro here
--> src/label.rs:209:25
|
209 | .map(|byte| format!("{byte:08b}"))
| ^^^^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `-D clippy::format-collect` implied by `-D warnings`
Loading