Fix for Javascript compiler #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for the issue with FireLess and the clientside javascript compilerversion of LessCompiler 0.8.1 stable an earlier. Currently, when using the JavaScript compiler we have the issue described by Bass Jobsen on http://bassjobsen.weblogs.fm/fireless-less-v2/ The name and the path (tooltip) of the lessfile and the linenumbers gets bit crippled and because of that bad readable. Very annoying. Bass Jobsen describes a solution for LESS 2 compiler with a plugin for Less 2. Alas in current Joomla we still stick to LESS 1.3.3. I'm not a regular expression expert, but I managed to port the solution of Bass to the less-1.3.3.js files.
Fix for the issue with FireLess and the clientside javascript compilerversion of LessCompiler 0.8.1 stable an earlier. Currently, when using the JavaScript compiler we have the issue described by Bass Jobsen on http://bassjobsen.weblogs.fm/fireless-less-v2/ The name and the path (tooltip) of the lessfile and the linenumbers gets bit crippled and because of that bad readable. Very annoying. Bass Jobsen describes a solution for LESS 2 compiler with a plugin for Less 2. Alas in current Joomla we still stick to LESS 1.3.3. I'm not a regular expression expert, but I managed to port the solution of Bass to the less-1.3.3.js files.
|
Hi @Klipper thanks a lot for your pull request! I will test it later today and merge it. |
|
Hi @ndeet, any progress with testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andreas,
Update less-1.3.3.js and less-1.3.3.min.js …
Fix for the issue with FireLess and the clientside javascript compilerversion of LessCompiler 0.8.1 stable and earlier.
Currently, when using the JavaScript compiler we have the issue described by Bass Jobsen on http://bassjobsen.weblogs.fm/fireless-less-v2/
The name and the path (tooltip) of the lessfile and the linenumbers gets bit crippled and because of that bad readable. Very annoying.
Bass Jobsen describes a solution for LESS 2 compiler with a plugin for Less 2. Alas in current Joomla we still stick to LESS 1.3.3.
I'm not a regular expression expert, but I managed to port the solution of Bass to the less-1.3.3.js files.
Screencaptures: http://img.aharef.nl/fixJavascriptcompilerFireless.png