cmake: use CMAKE_INSTALL_FULL_* in the pc file #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes possible to use absolute paths in `CMAKE_INSTALL_LIBDIR`. The current situation can causes troubles in some environment notably nixpkgs/NixOS. See https://github.com/jtojnar/cmake-snips?tab=readme-ov-file#assuming-cmake_install_dir-is-relative-path for more details.
|
Please open pull requests aka. merge requests in iniparser/iniparser. |
eworm-de
pushed a commit
to eworm-de/iniparser
that referenced
this pull request
Jun 17, 2024
This reverts commit 4b1e33a which was the result of a misunderstanding regarding issue ndevilla#165. The issue was not about the actual header location but, as its title already states: "includedir should point to the iniparser directory".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes possible to use absolute paths in
CMAKE_INSTALL_LIBDIR. The current situation can causes troubles in some environment notably nixpkgs/NixOS.See https://github.com/jtojnar/cmake-snips?tab=readme-ov-file#assuming-cmake_install_dir-is-relative-path for more details.