Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Validator Project Enhancement: Added Comprehensive Email Validation #329

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

m-hassanqureshi
Copy link

@m-hassanqureshi m-hassanqureshi commented Jan 18, 2025

Description

This pull request adds new features to the existing email validation script, enhances the functionality by including support for customizable error messages, and improves logging capabilities. Additionally,README file has been updated to reflect these changes.

Fixes #328

  • Issue_no: #328
  • Not applicable

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • New project insert
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Project

  • Address Validator Project :

  • Short Description: This project validates email addresses, checking for correct format, DNS records, and internationalized domain names (IDNs). The new features include customizable error messages, enhanced logging for better debugging.

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given [README_TEMPLATE].
  • My changes do not produce any warnings.

Refactored email validation code for clarity and maintainability. Improved function naming and added docstrings for better documentation. Simplified the disposable domain check and enhanced error handling. Ensured consistent variable usage throughout the code.
I will add these requirements in repo requirements.txt
Copy link

@fqshah1 fqshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice enhancements but we might need more enhacements to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address Validator Project Enhancement: Add Comprehensive Email Validation
2 participants