-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peakusage #113
Add peakusage #113
Conversation
These include (since 1.6) the water mater messages. And since 1.7.X also peak usage values. https://maakjemeterslim.be/rails/active_storage/blobs/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBZ0lEIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--cdd9b48fd0838e89b177f03b745b23450fd8f53e/e-MUCS_P1_Ed_1_7_1.pdf?disposition=attachment
f1f9d9f
to
d05fe26
Compare
@ndokter: Could you check and merge? :) |
Thanks for your hard work. I've merged the changes and will make a new build soon (within 2 weeks) You too @dennissiemensma! Although i'm not entirely sure if i already want to remove 3.6 support yet |
Thanks! I'll check it whenever I'll work on dsmrreader/dsmr-reader#1764. DSMR-reader uses a kind of forked version, but I still update it every now and then when there is a good reason to (now there is). |
It's entirely up to you. There is no right or wrong. If I may give some unasked advise, you can use semver to solve these issues. Just bump the major version of your package and drop end-of-life versions of Python (and dependencies) in it. |
As the new Fluvius DSMR Standard (V1.7.1) now also returns peak values and a history of them, this needs to be added to the DSMR parser.
This pull request does this :)
Please comment. But I implemented the test, and it works fine :)