test: multi signature production #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st/multi-signature-production
volovyks
reviewed
Aug 1, 2024
| .into_iter() | ||
| .unzip(); | ||
|
|
||
| match wait_for::signatures_responded(&ctx, &tx_hashes).await { |
There was a problem hiding this comment.
From what I see in signatures_responded() fn there is no guarantee that it will return all signatures. Some may be in progress. Should we check the length here? Or make sure we have N signatures in the function?
ailisp
reviewed
Aug 2, 2024
| Ok(Outcome::Failed(err)) => { | ||
| return Err(WaitForError::Signature(SignatureError::Failed(err))) | ||
| } | ||
| Err(_) => continue, |
There was a problem hiding this comment.
This may result in one result pushed more than once to result, I suggest use a Map and skip checking already in Map hashs.
ailisp
reviewed
Aug 2, 2024
|
|
||
| match wait_for::signatures_responded(&ctx, &tx_hashes).await { | ||
| Ok(_signatures) => tracing::info!(?tx_hashes, "got signatures"), | ||
| Err(err) => tracing::error!("unable to produce signatures in time: {err:?}"), |
There was a problem hiding this comment.
Would be helpful to collect some metrics: success percentage, average signature time. and we can compare daily result to know if our system is improved or hitting some regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in test for doing signature production chaotically throughout a whole entire test