-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /msg to criteria of active participants #894
Conversation
6201a06
to
58d7056
Compare
5d41dcb
to
6a73163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. How is empty message handled btw? If it's considered an error we may handle it as a proper status checking request
@@ -186,4 +197,20 @@ impl Pool { | |||
Err(_) => Err(FetchParticipantError::Timeout), | |||
} | |||
} | |||
|
|||
async fn test_empty_msg( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename this to send_empty_msg
instead since we should reserve test_*
functions for testing purposes
Seems like all the recent PRs are running into this issue:
I've tried compiling and running tests on a linux machine and they pass so not sure what's going on here. Could be a caching issue |
@ailisp can you please clean our cache? |
looking at mpc/chain-signatures/node/src/web/mod.rs Line 78 in ecc6fd3
|
a6e27ee
@volovyks done |
added
test_empty_msg()
in the logic of establishing active participants.Now to qualify as an active participant: