Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /msg to criteria of active participants #894

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented Oct 15, 2024

added test_empty_msg() in the logic of establishing active participants.
Now to qualify as an active participant:

  1. /state returns response fine;
  2. sending empty message thru send_encrypted() returns Ok(());

@ppca ppca changed the title add /msg to criteria of active add /msg to criteria of active participants Oct 15, 2024
@ppca ppca force-pushed the xiangyi/tune_refresh_intervals branch from 6201a06 to 58d7056 Compare October 16, 2024 18:59
Base automatically changed from xiangyi/tune_refresh_intervals to develop October 17, 2024 14:47
@ppca ppca force-pushed the xiangyi/msg_as_active_check branch from 5d41dcb to 6a73163 Compare October 17, 2024 20:17
@ppca ppca marked this pull request as ready for review October 17, 2024 20:17
ailisp
ailisp previously approved these changes Oct 18, 2024
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. How is empty message handled btw? If it's considered an error we may handle it as a proper status checking request

ChaoticTempest
ChaoticTempest previously approved these changes Oct 18, 2024
@@ -186,4 +197,20 @@ impl Pool {
Err(_) => Err(FetchParticipantError::Timeout),
}
}

async fn test_empty_msg(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this to send_empty_msg instead since we should reserve test_* functions for testing purposes

@ChaoticTempest
Copy link
Member

Seems like all the recent PRs are running into this issue:

Error: Action #0: CompilationError(PrepareError(Deserialization))

I've tried compiling and running tests on a linux machine and they pass so not sure what's going on here. Could be a caching issue

@volovyks
Copy link
Collaborator

@ailisp can you please clean our cache?

volovyks
volovyks previously approved these changes Oct 21, 2024
@ppca
Copy link
Contributor Author

ppca commented Oct 21, 2024

Looks good to me. How is empty message handled btw? If it's considered an error we may handle it as a proper status checking request

looking at

for encrypted in encrypted.into_iter() {
, the empty message will just return Ok(()) and not do anything else.

@ppca ppca dismissed stale reviews from volovyks, ChaoticTempest, and ailisp via a6e27ee October 21, 2024 18:07
@ailisp
Copy link
Member

ailisp commented Oct 22, 2024

@volovyks done

@ppca ppca merged commit a8fa2aa into develop Oct 25, 2024
3 checks passed
@ppca ppca deleted the xiangyi/msg_as_active_check branch October 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants