Make sure triples and presignatures are not reused #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
commented
Nov 19, 2024
| @@ -8,7 +8,7 @@ use near_account_id::AccountId; | |||
| type TripleResult<T> = std::result::Result<T, anyhow::Error>; | |||
|
|
|||
| // Can be used to "clear" redis storage in case of a breaking change | |||
| const TRIPLE_STORAGE_VERSION: &str = "v1"; | |||
| const TRIPLE_STORAGE_VERSION: &str = "v2"; | |||
There was a problem hiding this comment.
Incrementing the storage version here to start from scratch.
volovyks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be more strict on how we manage triples and presignatures. Not sure if it's causing this #924 and other issues, but we should make this change anyway. Rare occasions where we lose triples or presignatures is a low price for robustness.
Triples:
Presignatures: