Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote RPC for backward compatibility of testing #1283

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

denbite
Copy link
Contributor

@denbite denbite commented Jan 28, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Although the migration to near-workspaces for testing was a great idea (#1211), it doesn't work on M1 chips as expected, causing a lot of WasmerCompileErrors

image

This Pull Request extends the testing configuration file with the previous remote RPC option available by another key remote_ci, so developers will be able to decide on their own which option to use just by adjusting NODE_ENV environment variable

Test Plan

Related issues/PRs

#1211

Copy link

changeset-bot bot commented Jan 28, 2024

⚠️ No Changeset found

Latest commit: 90755e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vikinatora
Copy link
Collaborator

That's strange, I'm using M2 Pro currently and I don't have the same issue. Will have to investigate further.

@denbite
Copy link
Contributor Author

denbite commented Jan 29, 2024

it's really weird, I couldn't figure out the cause of the issue, but it keeps happening all the time, we might consider creating another PR for this

anyway, the purpose of this RP is to provide the remote CI RPC option and let developers choose

@denbite denbite changed the title Add remote RPC for testing backward compatibility Add remote RPC for backward compatibility of testing Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

2 participants