-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAL-110 - Lock / Unlock components and workflows for encrypting accessing local storage private key #2527
base: master
Are you sure you want to change the base?
Conversation
Your Render PR Server URL is https://near-wallet-pr-2527.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8p31qonlkia0dchtje0. |
@@ -2,6 +2,26 @@ import PropTypes from 'prop-types'; | |||
import React from 'react'; | |||
import styled from 'styled-components'; | |||
|
|||
const backgroundColorMap = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice mapping of colors! I'm curious why you decided to use this button component vs the regular FormButton
? Seems it would be good if we used the same button as much as possible for consistency sake, and less components to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely. Will switch to the FormButton.
@gutsyphilip is this PR ready for review? If not, can you please mark it as in progress / draft? |
It was ready for review @Patrick1904. But I did the UI for the passphrase task (WAL-37) in here because it was part of the design. I'm now working to revert that and then create a separate PR for that(tied to that ticket particularly). |
Thanks for clarifying. I converted this to draft for now so please convert it back when it's ready and request a review :) |
In this PR: