-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added token cache reset interval of one week #3038
base: master
Are you sure you want to change the base?
Conversation
👷 Deploy request for glittering-pavlova-0e9247 pending review.Visit the deploys page to approve it
|
👷 Deploy request for near-wallet-staging pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading this correctly, this change will only reset the cache if it hasn't been updated for a week -- in the case of a poisoned cache, it may be updated regularly but still invalid -- we want to intermittently clear the cache even if we've updated it regularly and recently. To accomplish this, we will need to set a separate timestamp to track the age of the cache since originally created, then check against that value instead of the last updated timestamp.
👷 Deploy request for unrivaled-zabaione-2fe19c pending review.Visit the deploys page to approve it
|
Updated accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 changes, then this is ready to go.
Hey @andy-haynes , would you mind checking this PR from before? Thanks! |
A large amount of users are raising an issue that they can't see fungible tokens in their near wallet. Indexer and RPC endpoints are returning the tokens correctly, but the issue is still there. There is a big chance that it the problem with the near wallet caching not updating properly.
I added a cache reset for every week so that the cache is synced with the blockchain.