Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new api in validate_chunk_headers #12265

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Oct 18, 2024

No description provided.

@stedfn stedfn self-assigned this Oct 18, 2024
@stedfn stedfn changed the base branch from master to stefan/missing_chunks October 18, 2024 13:10
@stedfn stedfn changed the title chore: use new api chore: use new api in validate_chunk_headers Oct 18, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (a2d112a) to head (99f5e4b).

Files with missing lines Patch % Lines
chain/chain/src/chain.rs 45.00% 11 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           stefan/missing_chunks   #12265      +/-   ##
=========================================================
- Coverage                  71.64%   71.64%   -0.01%     
=========================================================
  Files                        838      838              
  Lines                     167455   167455              
  Branches                  167455   167455              
=========================================================
- Hits                      119981   119980       -1     
+ Misses                     42244    42241       -3     
- Partials                    5230     5234       +4     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.25% <0.00%> (ø)
integration-tests 38.88% <57.69%> (-0.01%) ⬇️
linux 71.30% <57.69%> (-0.01%) ⬇️
linux-nightly 71.24% <57.69%> (+0.01%) ⬆️
macos 52.84% <57.69%> (-1.45%) ⬇️
pytests 1.56% <0.00%> (ø)
sanity-checks 1.37% <0.00%> (ø)
unittests 65.36% <57.69%> (-0.02%) ⬇️
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from stefan/missing_chunks to master October 23, 2024 10:20
@stedfn stedfn changed the base branch from master to stefan/rename_iter October 23, 2024 13:36
Base automatically changed from stefan/rename_iter to master October 24, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant