Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bandwidth_scheduler) - generate bandwidth requests based on receipts in outgoing buffers v2.0 #12464

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

feat(bandwidth_scheduler) - generate bandwidth requests based on receipts in outgoing buffers v2.0 #12464

wants to merge 45 commits into from

Commits on Nov 14, 2024

  1. Add StateStoredReceiptV1

    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cc672a2 View commit details
    Browse the repository at this point in the history

  2. Make TrieQueue generic over item type 

    Currently TrieQueue allows only storing
receipts. I would like to store other things
in a TrieQueue, let's make the item type generic.
    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    67b48a8 View commit details
    Browse the repository at this point in the history

  3. Rename TrieQueue::push to TrieQueue::push_back

    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0ce833f View commit details
    Browse the repository at this point in the history

  4. Rename TrieQueue::pop to pop_front

    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2e35da0 View commit details
    Browse the repository at this point in the history

  5. Add TrieQueue::pop_back

    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8f1118b View commit details
    Browse the repository at this point in the history

  6. Add TrieQueue::modify_first

    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b2ab786 View commit details
    Browse the repository at this point in the history

  7. Add OutgoingMetadatas and ReceiptGroupQueue

    @jancionear
    jancionear committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c96a26a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Add Trie columns to store receipt groups data

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6f152c5 View commit details
    Browse the repository at this point in the history

  2. Remove the comment about column=15 being a problem

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    41909b3 View commit details
    Browse the repository at this point in the history

  3. Pass shard_uids to estimator::apply_action_receipt 

    They will be needed to load the OutgoingMetadatas
in the next commit. I put these changes in a separate
commit for clarity.
    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    101f7fa View commit details
    Browse the repository at this point in the history

  4. Maintain outgoing buffer metadatas in ReceiptSink

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8531d80 View commit details
    Browse the repository at this point in the history

  5. Refactor ReceiptSink

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    686b146 View commit details
    Browse the repository at this point in the history

  6. Take iterator over results when creating a bandwidth request 

    TrieQueueIterator returns Result<Item, StorageError>,
so it can't be passed to the function that crates a bandwidth request.
Modify the function to take iterators over results instead
of iterators over values.
    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c48b403 View commit details
    Browse the repository at this point in the history

  7. Generate bandwidth requests

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6975fac View commit details
    Browse the repository at this point in the history

  8. Update protocol schema checksums

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f55eba7 View commit details
    Browse the repository at this point in the history

  9. Fix protocol schema again

    @jancionear
    jancionear committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3fd8ccf View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Simplify Item definition in ReceiptIterator 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2ae2ed0 View commit details
    Browse the repository at this point in the history

  2. TrieQueue::Item instead of Receipt in error message 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4da8f44 View commit details
    Browse the repository at this point in the history

  3. Fix Parameters typo 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    eaef8e6 View commit details
    Browse the repository at this point in the history

  4. Fix Needed typo 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d8526d3 View commit details
    Browse the repository at this point in the history

  5. Fix needed typo 2 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5a6b66a View commit details
    Browse the repository at this point in the history

  6. Remove lifetime from ReceiptSink 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    638b7ac View commit details
    Browse the repository at this point in the history

  7. Fix initialized typo 

    Co-authored-by: Shreyan Gupta <[email protected]>
    @jancionear @shreyan-gupta
    jancionear and shreyan-gupta authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    54de07b View commit details
    Browse the repository at this point in the history

  8. substract without the s

    @jancionear
    jancionear committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5688e31 View commit details
    Browse the repository at this point in the history

  9. Add Cow TODO

    @jancionear
    jancionear committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1e60e18 View commit details
    Browse the repository at this point in the history

  10. remove lower_bound, set upper_bound to 100kB

    @jancionear
    jancionear committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    249a693 View commit details
    Browse the repository at this point in the history

  11. Rename trie columns

    @jancionear
    jancionear committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    628f19e View commit details
    Browse the repository at this point in the history

  12. Fix protocol schema check after renaming trie column

    @jancionear
    jancionear committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0ed79be View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Test TrieQueue operations

    @jancionear
    jancionear committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b725792 View commit details
    Browse the repository at this point in the history

  2. Test ReceiptGroupsConfig

    @jancionear
    jancionear committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d460162 View commit details
    Browse the repository at this point in the history

  3. Write indices after modification in TrieQueue::modify_first

    @jancionear
    jancionear committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b432b08 View commit details
    Browse the repository at this point in the history

  4. Add get_random_receipt_size_for_test

    @jancionear
    jancionear committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0364d5e View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Test ReceiptGroupsQueue

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e313e21 View commit details
    Browse the repository at this point in the history

  2. Test that receipt groups produce optimal bandwidth requests

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    02f2203 View commit details
    Browse the repository at this point in the history

  3. Use FnMut in TestLoop::run_until

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dbe0f7e View commit details
    Browse the repository at this point in the history

  4. Add TransactionRunner

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    30cf08e View commit details
    Browse the repository at this point in the history

  5. Add run_txs_parallel

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5e96672 View commit details
    Browse the repository at this point in the history

  6. Bandwidth request generation testloop test

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b035296 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into jan-generate-requests-v2

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7a117aa View commit details
    Browse the repository at this point in the history

  8. Fix nightly feature flags

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4e064a5 View commit details
    Browse the repository at this point in the history

  9. Revert "Pass shard_uids to estimator::apply_action_receipt" 

    This reverts commit 101f7fa.
    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    abd7d6c View commit details
    Browse the repository at this point in the history

  10. Hardcode shard_id in estimator::apply_action_receipt

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    fc571ce View commit details
    Browse the repository at this point in the history

  11. Don't keep ReceiptGroupsConfig in ReceiptGroupsQueue

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    740bf2a View commit details
    Browse the repository at this point in the history

  12. Rename receiver_shard to receiving_shard

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    752fb6e View commit details
    Browse the repository at this point in the history

  13. Grammar fix

    @jancionear
    jancionear committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    78eb384 View commit details
    Browse the repository at this point in the history